Fix bug of latitude longitude mismatch

hebcal / hebcal-js

⛔️ DEPRECATED - a perpetual Jewish Calendar (JavaScript)

GNU General Public License v3.0

123 stars 40 forks source link

Fix bug of latitude longitude mismatch #48

Closed haimkastner closed 5 years ago

haimkastner commented 6 years ago

The first value in 'lat' array (when using setCity method) are the latitude and not the longitude

Scimonster commented 5 years ago

Thanks for this! I'm bad at this coordinate stuff. (And maintaining, apparently.)

avrAhituv commented 5 years ago

Thanks!! i want to check if this fix my bug, update this in npm package?

Scimonster commented 5 years ago

@avrAhituv Working on a release right now

avrAhituv commented 5 years ago

Thank you very much!! I really appreciate your work.

Scimonster commented 5 years ago

v2.3.0 is live on NPM

haimkastner commented 5 years ago

Thanks for the npm update and project maintaining. And it really sounds that this is the bug #51 , because in israel the latitude and longitude are very close. So if we switch latitude (~32 deg) and longitude (~35 deg) in jerusalem, should be a difference of about 15 minutes.