test: added a sanity test for the package

hebcal / hebcal-js

⛔️ DEPRECATED - a perpetual Jewish Calendar (JavaScript)

GNU General Public License v3.0

124 stars 40 forks source link

test: added a sanity test for the package #71

Closed barakplasma closed 5 years ago

barakplasma commented 5 years ago

I added a very simple sanity test file to verify a few of the documented API methods. I would prefer to rewrite it using Jest as the test runner, but I didn't want to introduce any new dependencies. If you are open to adding Jest as a dev dependency, please let me know and it'll improve the tests dramatically.

Scimonster commented 5 years ago

Looks good. I was young and stupid when i did this originally and, now am a little older and less stupid.

Adding Jest is fine. I can either merge this as is, or let you redo it and merge later.

In the future, when you make a pull request, it's best to do from a branch on your fork and not master.

barakplasma commented 5 years ago

I plan on adding Jest in two weeks.

barakplasma commented 5 years ago

Closing in favor of #76