Time not Factored into new HDate?

hebcal / hebcal-js

⛔️ DEPRECATED - a perpetual Jewish Calendar (JavaScript)

GNU General Public License v3.0

123 stars 40 forks source link

Time not Factored into new HDate? #85

Closed MDjavaheri closed 3 years ago

MDjavaheri commented 3 years ago

The readme states Before v2.2: If the date is after sunset, it is the next day. Why is this so? I have a datepicker that converts from Gregorian to Hebrew and it won't take the time into account seemingly for this reason. March 3, 2021 8:00 PM => 19 Adar 5781 && March 3, 2021 8:00 AM=>19 Adar 5781 But why?! Do I have to manually trick it to produce the next day if it's after sunset?

MDjavaheri commented 3 years ago

Issue addressed by @mjradwin in the es6 repo. Thank you!