Pesach VII (on Shabbat) has no Hebrew translation

hebcal / hebcal-leyning

Javascript Torah Reading API for Parashat HaShavua and holidays

https://hebcal.github.io/api/leyning/

BSD 2-Clause "Simplified" License

9 stars 2 forks source link

Pesach VII (on Shabbat) has no Hebrew translation #462

Closed SLaks closed 6 days ago

SLaks commented 6 days ago

Demo:

  name: [object Object] {
    en: "Pesach VII (on Shabbat)",
    he: undefined
  },

The last day is also missing translation

mjradwin commented 6 days ago

Thanks for the bug report and pull request. I may end up refactoring this and moving these strings and a bunch more from https://github.com/hebcal/hebcal-es6/blob/main/po/he.po to a dedicated he.po file in the hebcal-leyning repo.

That would reduce bundle size a bit for @hebcal/core users who don't also need the leyning, but it won't make a huge difference because @hebcal/core is already gigantic due to the dependencies that Zmanim pulls in...