hebench / reference-palisade-backend

The PALISADE-CPU backend is a Reference backend engine for HEBench which is a shared library that implements the required functions specified in either the hebench::APIBridge or hebench::cpp wrapper. It is intended only as a reference on how to implement a PALISADE backend for HEBench and it is not fully optimized for performance.
Apache License 2.0
6 stars 2 forks source link

Configuration File Values don't have Priority over Engine-Passed Values #36

Closed kylanerace closed 2 years ago

kylanerace commented 2 years ago
Version Information (Put N/A for Not Applicable) Software Version(s)
Linux Ubuntu 20.04
Git 2.25.1
CMake 3.16.3
Compiler (GCC, Clang, etc.) gcc 10.3.0
GLIBC (ldd) 2.31
Doxygen 1.9.1
HEBench Frontend 0.6.2-beta
HEBench API Bridge v0.6.0-beta
Reference Backend dffaf01*

*Also caught development up to main first

Describe the bug
Using a configuration file without modifying the backend will result in the config-file batch size passed to LR getting ignored (for offline category only).

To Reproduce
Steps to reproduce the behavior:

  1. Pull Down this repo (backend-cpu-palisade) git clone https://github.com/hebench/backend-cpu-palisade.git
  2. Switch to the development branch cd backend-cpu-palisade && git checkout development
  3. Build and Run to Generate a configuration file from the default backend mkdir build && cd build cmake -DCMAKE_INSTALL_PREFIX=. -DCMAKE_BUILD_TYPE=Release .. && make -j install ./bin/test_harness -b ./libhebench_palisade_backend.so --config_file testing.yml --dump
  4. Edit the configuration file and run with the updated file testing.txt See edited config file above with batch size = 15 (Change the above file type to "yml" before running) ./bin/test_harness -b ./libhebench_palisade_backend.so --config_file testing.yml
  5. See that custom batch size passed by configuration file is ignored Output will still have batch size passed from engine file and instead of custom batch size in config: , Category, Offline , , Parameter, Samples requested , , 0, 1 , , 1, 1 , , 2, 100

Expected behavior
The expectation is that the value passed in the configuration file has priority

Screenshots
N/A

Additional context
N/A