Closed wooosh closed 1 year ago
@wooosh Thank you, I completely forgot this. Should we also impl Error?
edit: will merge tomorrow, if you wanna add impl Error
you can do so, otherwise I'll do that right after.
I did not implement Error
because as far as I can tell, it would prevent this package from being no-std
on stable rust (https://github.com/rust-lang/rust/issues/103765).
Ah, if it's just available in core
on nightly
, it would be better behind our nightly feature gate.
But since:
feature(error_in_core)
everywherelet's keep it at this for now.
again, thank you @wooosh, have a good one!
This patch rectifies
BitsError
not satisfying the constraints of theError
trait due to not implementing theDisplay
trait.