hechoendrupal / drupal-console-core

This project contains commands and features to be shared across DrupalConsole projects.
134 stars 69 forks source link

Generator class don't uses GeneratorInterface #360

Open edysmp opened 5 years ago

edysmp commented 5 years ago

I see we have a GeneratorInterface but we don't use it, at least in Generator class.

I am creating a command which uses Generator feature, the generate:command by defualt set to use \Drupal\Console\Core\Generator\GeneratorInterface as paramater signature of my Command class. I get a TypeError like: MyGeneratorClass must implement interface GeneratorInterface.

edysmp commented 5 years ago

I fix this error whe i implements GeneratorInterface in my CustomGenerator. I see that generate:command generates this by default. But still should we implement this interface in the base Generator class instead?