hechoendrupal / drupal-console-core

This project contains commands and features to be shared across DrupalConsole projects.
134 stars 69 forks source link

PHP8 deprecation warnings #388

Open Muffinman opened 3 years ago

Muffinman commented 3 years ago

NestedArray::yamlSplitArray() throws deprecation warnings on PHP8.0+ due to required parameters following optional ones:

Deprecated function: Required parameter $exclude_parents_key follows optional parameter $indent_level in include() (line 444 of /home/[redacted]/gitrepo/vendor/composer/ClassLoader.php)
#0 /home/[redacted]/gitrepo/web/core/includes/bootstrap.inc(312): _drupal_error_handler_real()
#1 /home/[redacted]/gitrepo/vendor/composer/ClassLoader.php(444): _drupal_error_handler()
#2 /home/[redacted]/gitrepo/vendor/composer/ClassLoader.php(444): include()
#3 /home/[redacted]/gitrepo/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile()
#4 [internal function]: Composer\Autoload\ClassLoader->loadClass()
#5 /home/[redacted]/gitrepo/vendor/symfony/dependency-injection/ContainerBuilder.php(1142): ReflectionClass->__construct()
#6 /home/[redacted]/gitrepo/vendor/symfony/dependency-injection/ContainerBuilder.php(618): Symfony\Component\DependencyInjection\ContainerBuilder->createService()
#7 /home/[redacted]/gitrepo/vendor/symfony/dependency-injection/ContainerBuilder.php(1267): Symfony\Component\DependencyInjection\ContainerBuilder->doGet()
#8 /home/[redacted]/gitrepo/vendor/symfony/dependency-injection/ContainerBuilder.php(1215): Symfony\Component\DependencyInjection\ContainerBuilder->doResolveServices()
#9 /home/[redacted]/gitrepo/vendor/symfony/dependency-injection/ContainerBuilder.php(1117): Symfony\Component\DependencyInjection\ContainerBuilder->doResolveServices()
#10 /home/[redacted]/gitrepo/vendor/symfony/dependency-injection/ContainerBuilder.php(618): Symfony\Component\DependencyInjection\ContainerBuilder->createService()
#11 /home/[redacted]/gitrepo/vendor/symfony/dependency-injection/ContainerBuilder.php(558): Symfony\Component\DependencyInjection\ContainerBuilder->doGet()
#12 /home/[redacted]/gitrepo/vendor/drupal/console-core/src/Application.php(468): Symfony\Component\DependencyInjection\ContainerBuilder->get()
#13 /home/[redacted]/gitrepo/vendor/drupal/console-core/src/Application.php(214): Drupal\Console\Core\Application->registerCommands()
#14 /home/[redacted]/gitrepo/vendor/drupal/console-core/src/Application.php(119): Drupal\Console\Core\Application->loadCommands()
#15 /home/[redacted]/gitrepo/vendor/drupal/console/src/Application.php(64): Drupal\Console\Core\Application->doRun()
#16 /home/[redacted]/gitrepo/vendor/symfony/console/Application.php(149): Drupal\Console\Application->doRun()
#17 /home/[redacted]/gitrepo/vendor/drupal/console/bin/drupal.php(89): Symfony\Component\Console\Application->run()
#18 /home/[redacted]/gitrepo/vendor/drupal/console/bin/drupal(4): require('...')
#19 {main}
    /**
     * @param array $array
     * @param array $split_array
     * @param int   $indent_level
     * @param array $key_flatten
     * @param int   $key_level
     * @param bool  $exclude_parents_key
     */
    public function yamlSplitArray(array &$array, array &$split_array, $indent_level = '', &$key_flatten, &$key_level, $exclude_parents_key)
    {
    ...
    }

Also NestedArray::arrayDiff() has the same issue:

Deprecated function: Required parameter $statistics follows optional parameter $negate in include() (line 444 of /home/[redacted]/gitrepo/vendor/composer/ClassLoader.php)
#0 /home/[redacted]/gitrepo/web/core/includes/bootstrap.inc(312): _drupal_error_handler_real()
#1 /home/[redacted]/gitrepo/vendor/composer/ClassLoader.php(444): _drupal_error_handler()
#2 /home/[redacted]/gitrepo/vendor/composer/ClassLoader.php(444): include()
#3 /home/[redacted]/gitrepo/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile()
#4 [internal function]: Composer\Autoload\ClassLoader->loadClass()
#5 /home/[redacted]/gitrepo/vendor/symfony/dependency-injection/ContainerBuilder.php(1142): ReflectionClass->__construct()
#6 /home/[redacted]/gitrepo/vendor/symfony/dependency-injection/ContainerBuilder.php(618): Symfony\Component\DependencyInjection\ContainerBuilder->createService()
#7 /home/[redacted]/gitrepo/vendor/symfony/dependency-injection/ContainerBuilder.php(1267): Symfony\Component\DependencyInjection\ContainerBuilder->doGet()
#8 /home/[redacted]/gitrepo/vendor/symfony/dependency-injection/ContainerBuilder.php(1215): Symfony\Component\DependencyInjection\ContainerBuilder->doResolveServices()
#9 /home/[redacted]/gitrepo/vendor/symfony/dependency-injection/ContainerBuilder.php(1117): Symfony\Component\DependencyInjection\ContainerBuilder->doResolveServices()
#10 /home/[redacted]/gitrepo/vendor/symfony/dependency-injection/ContainerBuilder.php(618): Symfony\Component\DependencyInjection\ContainerBuilder->createService()
#11 /home/[redacted]/gitrepo/vendor/symfony/dependency-injection/ContainerBuilder.php(558): Symfony\Component\DependencyInjection\ContainerBuilder->doGet()
#12 /home/[redacted]/gitrepo/vendor/drupal/console-core/src/Application.php(468): Symfony\Component\DependencyInjection\ContainerBuilder->get()
#13 /home/[redacted]/gitrepo/vendor/drupal/console-core/src/Application.php(214): Drupal\Console\Core\Application->registerCommands()
#14 /home/[redacted]/gitrepo/vendor/drupal/console-core/src/Application.php(119): Drupal\Console\Core\Application->loadCommands()
#15 /home/[redacted]/gitrepo/vendor/drupal/console/src/Application.php(64): Drupal\Console\Core\Application->doRun()
#16 /home/[redacted]/gitrepo/vendor/symfony/console/Application.php(149): Drupal\Console\Application->doRun()
#17 /home/[redacted]/gitrepo/vendor/drupal/console/bin/drupal.php(89): Symfony\Component\Console\Application->run()
#18 /home/[redacted]/gitrepo/vendor/drupal/console/bin/drupal(4): require('...')
#19 {main}
    /**
     * @param $array1
     * @param $array2
     * @param bool                   $negate if Negate is true only if values are equal are returned.
     * @param $statistics mixed array
     * @return array
     */
    public function arrayDiff($array1, $array2, $negate = false, &$statistics)
    {
    ...
    }