search

hechoendrupal / drupal-console-extend-plugin

Drupal Console Extend Composer Plugin
131 stars 31 forks source link

Add Composer 2 support #25

Closed ossobuffo closed 3 years ago

ossobuffo commented 3 years ago

Composer 2's PluginInterface has added two new methods. Adding stubs for these allows us to be compatible with composer-plugin-api ^2.0.

mbaynton commented 3 years ago

Possible fix for https://github.com/hechoendrupal/drupal-console-extend-plugin/issues/23

scotself commented 3 years ago

Yes please šŸ‘ One of the Drupal plugins keeping us from using composer 2.

pinoniq commented 3 years ago

Any idea on when this will be merged? This currently makes using drupal/console projects unusable with composer 2. Given that dev-tools like e.g. lando moved to composer2, this is rather a blocker. Is there anything I can do to get this merged?

bob-hinrichs commented 3 years ago

This is now blocking our projects, as Lando is also now on Composer 2 in its most recent release.

mukeshsah08 commented 3 years ago

Could you please merge this MR ASAP. It's required for my current project. Thanks!

bob-hinrichs commented 3 years ago

@pefferen and @trackleft - er, very sorry if I tagged the wrong people here. Who can merge this? My builds are no longer working on Pantheon because this is not merged yet.

mbaynton commented 3 years ago

We know this is causing compatibility issues with Pantheon's integrated composer build process. I reached out to @jmolivas, one of the original maintainers for Drupal Console, and it's on his radar. ETA by this weekend for a tagged release.

jmolivas commented 3 years ago

Tagging a new release this week

jmolivas commented 3 years ago

@ossobuffo Thanks for your contribution, your PR was merged. This will be included in the next release.

esolitos commented 3 years ago

@jmolivas That's great to hear! Do you have any idea when you'll tagging a release? :)

alex-belyaev commented 3 years ago

@jmolivas hi, is there any updates on new tag?

xtfer commented 3 years ago

Thats great @jmolivas, but this is now blocking drupal-console, which in turn is causing blockers on just about every build system running Drupal on the planet. :) Can we get a release?

driskell commented 3 years ago

If it helps - switching to use composer v1 makes this a minor problem. Iā€™m not aware of anything that requires composer v2 just yet that would ever make this a blocker.

Thereā€™s several options available. https://getcomposer.org/download/ Latest installer can be given --1 argument to download only v1. To fix any self updating build scripts the same argument can be appended to selfupdate. Also for GitHub Actions thereā€™s several actions available that can set up the right PHP and Composer versions as needed.

Composer v2 is quite new still so I can guess the testing and confidence in releasing an update can in some cases take some time.

BrianGilbert commented 3 years ago

@driskell Composer 1 is deprecated now, and Composer 2 is way faster.. ideally this can get fixed soon