search

hechoendrupal / drupal-console

The Drupal CLI. A tool to generate boilerplate code, interact with and debug Drupal.
http://drupalconsole.com
GNU General Public License v2.0
939 stars 560 forks source link

Clean up Generators commands from ExtensionManager #3966

Open LOBsTerr opened 5 years ago

LOBsTerr commented 5 years ago

Issue title

Because we moved the Code of Generators to separate service in many cases ExtensionManager is not used any more

Solution

Remove extension managers from the definition of the commands and constructors

LOBsTerr commented 5 years ago

PR https://github.com/hechoendrupal/drupal-console/pull/3968

@jmolivas 1) I propose create a new class ModuleAwareCommand, which will be a Base classes for the commands, which generate the code inside of a module. 2) Like this we get rid off Module trait 3) All these commands are using the same traits, the same methods and fields

If you will confirm this idea, I will continue and will convert the code

enzolutions commented 5 years ago

@LOBsTerr I think this is a good idea, could you continue with this approach to be included in Drupal Console 2.0?