hechtus / squeezebox-googlemusic

Squeezebox (Logitech Media Server) Plugin for Google Play Music
103 stars 24 forks source link

gmusicapi version check thinks v10 is older than v4 #100

Open digiltd opened 8 years ago

digiltd commented 8 years ago

When trying to wrestle with getting Google Music working on my Pi as once again it stopped working, I installed the latest gmusicapi which is now at version 10.

This causes the plugin to say:

A more recent version of the Python package "gmusicapi" is required. Please install at least version 3.1.0 and restart Logitech Media Server.

You can remove this check by editing the Plugin.pm file line 61

# Chech version of gmusicapi first
    if (!blessed($googleapi) || (Plugins::GoogleMusic::GoogleAPI::get_version() lt '4.0.0')) {
        $class->SUPER::initPlugin(
            tag    => 'googlemusic',
            feed   => \&badVersion,
            is_app => 1,
            weight => 1,
            );
        return;
    }

I tried changing '4.0.0' to '15.0.0' which didn't seem to work as i expected it.

So I ended removing the conditional for the version completely.

# Chech version of gmusicapi first
    if (!blessed($googleapi)) {
        $class->SUPER::initPlugin(
            tag    => 'googlemusic',
            feed   => \&badVersion,
            is_app => 1,
            weight => 1,
            );
        return;
    }

This didn't fix the signing in issues though. The problem is with the 2FA and or application passwords.

I gave up and created a new Google account and uploaded all my music to the new account.

This doesn't have 2FA and so far it is logging on every time.

Not ideal, and I might have a sit down and try to figure out what the problem is with the current plugin. But the constant restarting of the media server every time i changed something was driving me mad. Is there another way for force a reload of the plugins without a full restart?

cloudmusic201 commented 8 years ago

i get the same message and it's frustrating. Anyway to fix?

digiltd commented 8 years ago

The A more recent version of message?

Find where it checks for the version and remove it, as described above :)

askvictor commented 8 years ago

I'm doing active development on this plugin at https://github.com/squeezebox-googlemusic/squeezebox-googlemusic - hechtus is MIA. This issue is fixed in my repo.

crystalgipsy commented 8 years ago

Cant get this plugin to load at all on Vortexbox 2.4 Installed all the bits needed but it wont load the plugin up at all, just get this error in the log

[16-07-10 16:40:41.4006] Slim::bootstrap::tryModuleLoad (286) Warning: Module [Plugins::GoogleMusic::Plugin] failed to load: Error -- py_eval raised an exception at /usr/lib64/perl5/vendor_perl/Inline/Python.pm line 177. BEGIN failed--compilation aborted at /var/lib/squeezeboxserver/cache/InstalledPlugins/Plugins/GoogleMusic/GoogleAPI.pm line 74. Compilation failed in require at /var/lib/squeezeboxserver/cache/InstalledPlugins/Plugins/GoogleMusic/Settings.pm line 20. BEGIN failed--compilation aborted at /var/lib/squeezeboxserver/cache/InstalledPlugins/Plugins/GoogleMusic/Settings.pm line 20. Compilation failed in require at /var/lib/squeezeboxserver/cache/InstalledPlugins/Plugins/GoogleMusic/Plugin.pm line 24. BEGIN failed--compilation aborted at /var/lib/squeezeboxserver/cache/InstalledPlugins/Plugins/GoogleMusic/Plugin.pm line 24. Compilation failed in require at (eval 891) line 1. BEGIN failed--compilation aborted at (eval 891) line 1.