hechtus / squeezebox-googlemusic

Squeezebox (Logitech Media Server) Plugin for Google Play Music
103 stars 24 forks source link

"Start Radio" menu item on logitech squeezebox controller app #42

Open mikeybs opened 10 years ago

mikeybs commented 10 years ago

If something is currently playing then the "Start Radio" menu item on logitech squeezebox controller app (iphone version, not sure about android) does not work as expected. It displays info about the "Start radio" menu item, displaying the following on screen:

Title: Start radio URL: googlemusicradio:artist:xxx

The way to get it working is to tap and hold the "Start Radio" menu item which brings up the context menu and gives you the options of -Add to end -Play next -Play -Save to Favorites

It would be nice if on a single tap of the menu item it would either just start playing the radio or bring up the context menu.

If nothing is currently playing (the player is either paused or off), then a single tap of the menu item works nicely, and just begins playing the radio.

Also on the subject of Start radio, it would be nice to be able to start a radio station based on a track, and not just on an artist. That can be done using the google music web interface or android/iphone apps. I'd love to be able to do it within squeezebox as well. I can open up a separate issue for that if necessary...

hechtus commented 10 years ago

Regarding "Start Radio". Does the same issue apply to "My Radio Stations"? I Also experienced that at some LMS version single tap does not work anymore. If something is currently playing a context menu opens asking what you want to do (Add to end, play next, ...). When I was starting to work on this plugin with LMS 7.7.3 this does not happen.

@mherger Do you have an idea, why context menus are appear when I would expect single-tap to playall?

Regarding start radio based on track or album. I'm already thinking of this. This would require some nice context menus (tap and hold). Do you have any other suggestions? Could it be another menu in the track info menu where you can also find "On Google Music"?

mherger commented 10 years ago

@hechtus - what exact menu do you get when tapping such an item?

Yes, you can register your own code to add items to a track item:

Slim::Menu::TrackInfo->registerInfoProvider( googlemusic => (
    func => sub { ... },
) );
hechtus commented 9 years ago

I just realized that the new LMS versions have a configuration setting in the players section. This setting forces to ask if you want to play something new.

hechtus commented 9 years ago

@mikeybs Try to disable this "Defeat destructive Touch-To-Play" option. In fact I also do not like this feature. In addition, I'm having serious problems to support the old squeezebox android app by Logitech when this option is on.

@mherger it seems that the on_select option in the track menu gets completely broken with the old squeezebox android app. Please have a look at this code https://github.com/hechtus/squeezebox-googlemusic/blob/v0.4/GoogleMusic/TrackMenu.pm#L66

hechtus commented 9 years ago

@mherger I just checked the behavior against the bandcamp plugin. When enabling "Defeat destructive Touch-To-Play" and using the Logitech squeezebox android app the track info items pop up when touching a track of an album. Instead, the play and play all menu should pop up. This wrong behavior completely forbids to play the album at all. For a long time I thought it was my fault. But it seems to be a combination of the new LMS 7.8 and the Logitech app.

hechtus commented 9 years ago

Just another note, when using a long touch the play, play all And the track info items pop up. So, playing an album is still possible but cumbersome.

mherger commented 9 years ago

Ugh... I never liked that "defeat destructive touch-to-play" feature. It's been added to 7.8 firmware (and server) when we were still planning to do an official 7.8 release. Unfortunately it never got implemented in all places. And tbh. I doubt the Controller app will see any update any more.