hecomi / uLipSync

MFCC-based LipSync plug-in for Unity using Job System and Burst Compiler
https://tips.hecomi.com/entry/2022/01/30/152519
MIT License
1.05k stars 128 forks source link

About unity version support #14

Closed kumi0708 closed 2 years ago

kumi0708 commented 2 years ago

Hello.

I would like to add uLipSync to the Git URL (UPM) Add https://github.com/hecomi/uLipSync.git#upm to Package Manager. I have installed uLipSync with

I installed uLipSync by using the Git URL (UPM) Add95 to Package Manager. However, I got an error message.

The problem is in line 160 of uLipSync

if (! _ratios.TryAdd(phoneme, ratio))

I found out that the TryAdd function in Dictionary is .

NET Standard 2.1. NET Standard 2.1. https://docs.microsoft.com/ja-jp/dotnet/api/system.collections.generic.dictionary-2.tryadd?view=net-6.0

NET Standard 2.1 support for unity seems to be available in Unity 2021.2 or later.

NET Standard 2.1 in unity seems to be supported in Unity 2021.2 or later. To begin with, is the supported version of unity in uLipSync 2021.2 or later? Or, if I run it on 2020.3.27f (LTS), is there another way to solve the error?

hecomi commented 2 years ago

Thank you for the report. I'll fix the issue soon not to use the .NET Standard 2.1 functions.

hecomi commented 2 years ago

v2.0.3 has been released, replacing some APIs that were causing errors in 2021.1 and earlier.

kumi0708 commented 2 years ago

Thank you for your support