MainEditor not excluded at build time

hecomi / uREPL

In-game powerful REPL environment for Unity3D.

http://tips.hecomi.com/entry/2015/12/05/003000

MIT License

552 stars 54 forks source link

MainEditor not excluded at build time #25

Closed robin-moss closed 2 years ago

robin-moss commented 2 years ago

When installing uREPL via the Git URL the MainEditor is no longer under the special Editor folder under assets, as so it's not actually excluded at build time.

This leads to the build failing because of the dependency on UnityEditor

To solve this we would need to modify the package to add #if (UNITY_EDITOR) around the entire file.

Could you update the MainEditor to use macros please?

hecomi commented 2 years ago

Thank you for the report! I'll fix it soon.

hecomi commented 2 years ago

uREPL.Editor.asmdef was added and the problem was fixed from v1.0.4. https://github.com/hecomi/uREPL/releases/tag/v1.0.4

robin-moss commented 2 years ago

Thank you, it works now