Update to wgpu 0.5 - Githubissues

hecrj / wgpu_glyph

A fast text renderer for wgpu (https://github.com/gfx-rs/wgpu)

https://docs.rs/wgpu_glyph

MIT License

450 stars 78 forks source link

Closed fintelia closed 4 years ago

fintelia commented 4 years ago

Lots of small changes; I needed to add a few dependencies

hecrj commented 4 years ago

Whoops... You may have missed #33 :sweat_smile:

hecrj commented 4 years ago

I see you've used bytemuck instead of zerocopy. It may be worth it if it improves the build times. But I am a bit scared of unsafe.

In any case, thank your for the effort here! :bow: Would love to know your opinions on my PR.

fintelia commented 4 years ago

Yeah... I probably should have looked a bit closer first. Anyway, I left a couple comments on that other PR and it looks quite reasonable to me.

Regarding bytemuck vs. zerocopy, I like the simplicity of bytemuck but totally understand the hesitation around adding unsafe.