hect0x7 / JMComic-Crawler-Python

Python API for JMComic | 提供Python API访问禁漫天堂,同时支持网页端和移动端 | 禁漫天堂GitHub Actions下载器🚀
https://jmcomic.readthedocs.io/zh-cn/latest/option_file_syntax/#
MIT License
791 stars 1.85k forks source link

v2.4.7: 实现收藏本子功能,优化代码和文档 #174

Closed hect0x7 closed 10 months ago

hect0x7 commented 10 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 10 months ago

[!WARNING]

Rate Limit Exceeded

@hect0x7 has exceeded the limit for the number of files or commits that can be reviewed per hour. Please wait 9 minutes and 8 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the @coderabbitai review command. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 9d422349932d7889fb6245148e42353ff37bfa02 and 4d138458e6795d45ef0513d36323768fd9d9caf6.

Walkthrough

The changes across various files reflect updates to method names, parameter descriptions, and functionality enhancements in a Python codebase. Key updates include renaming methods for filtering objects, refining parameter descriptions in YAML configurations, adding new methods for handling favorites and domain switching, and updating version numbers. Additionally, there are changes to type annotations and docstrings for better clarity and consistency.

Changes

File Path Change Summary
.github/workflows/...
assets/docs/sources/...
src/jmcomic/jm_downloader.py
src/jmcomic/jm_plugin.py
Updated parameter descriptions in YAML configurations.
Renamed filter_iter_objs to do_filter and updated related logic.
src/jmcomic/__init__.py Updated software version number.
src/jmcomic/jm_client_impl.py
src/jmcomic/jm_client_interface.py
Added new methods for favorites and domain handling, and updated existing methods.
src/jmcomic/jm_config.py Added new keys and attributes for configuration handling.
src/jmcomic/jm_entity.py Updated type annotations and added docstrings.
src/jmcomic/jm_option.py Refactored methods to remove and replace parameters.
src/jmcomic/jm_toolkit.py Added regex pattern and updated method for match handling.
tests/test_jmcomic/... Modified method calls in test cases.
usage/workflow_download.py Refactored environment variable handling function.

🐇✨ In the burrow of code, changes abound, Methods renamed, and new logic found. A version ticked up, a refactor so neat, A rabbit hops on, with updates complete. 🎉 🐇✨


Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - If you reply to a *review comment* from CodeRabbit, the bot will automatically respond. - To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment - Note: Review comments are made on code diffs or files, not on the PR overview. - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Note: For conversation with the bot, please use the review comments on code diffs or files. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json`
github-actions[bot] commented 10 months ago

To prevent beginners from mistakenly submitting PRs, if your PR only modifies the usage/workflow_download.py file, it will be automatically closed. If you really want to submit a PR, please reopen it yourself. Make sure you know what you are doing!