hect0x7 / JMComic-Crawler-Python

Python API for JMComic | 提供Python API访问禁漫天堂,同时支持网页端和移动端 | 禁漫天堂GitHub Actions下载器🚀
https://jmcomic.readthedocs.io/zh-cn/latest/option_file_syntax/#
MIT License
556 stars 1.18k forks source link

v2.5.10: 修正zip插件在压缩本子时未正确判断章节路径的问题 #225

Closed hect0x7 closed 2 months ago

hect0x7 commented 2 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

The update to JMComic version 2.5.10 enhances various aspects of the software. It includes improvements like updating version numbers, refining browser impersonation settings, optimizing plugin functionality for zip operations, and streamlining class methods for better file handling efficiency, especially in compression tasks.

Changes

File Path Change Summary
src/jmcomic/__init__.py Version updated from '2.5.9' to '2.5.10'.
src/jmcomic/jm_config.py
src/jmcomic/jm_option.py
- Updated new_postman function to use 'chrome110'.
- Removed decide_album_dir method from JmOption class.
src/jmcomic/jm_plugin.py Refactored zip_photo and zip_album methods to utilize dir_zip_dict for improved directory and zip file management.
assets/docs/sources/option_file_syntax.md - Adjusted email_notify parameters.
- Added guidance and warnings for zip plugin setup.
- Updated settings for favorite_folder_export plugin.
- Enhanced descriptions and prerequisites for j2p plugin.

Possibly related issues

🎉🐰📘

In the world of code, where the rabbits roam,
We tweaked and we twiddled, in our digital home.
With a hop and a skip, version two-five-one-oh,
Zip and compress, now smoother to go.
So here's to the changes, may they bring delight,
As we code through the day, and debug through the night.

🥕🌟📚


Recent Review Status **Configuration used: CodeRabbit UI**
Commits Files that changed from the base of the PR and between 2cae3fd28f7548feb6e5163cb4ea5b952dfe09df and 7365e434bed30e87373767960c2741e16cd53da3.
Files selected for processing (1) * assets/docs/sources/option_file_syntax.md (3 hunks)
Additional comments not posted (4)
assets/docs/sources/option_file_syntax.md (4)
`182-189`: Clarify the relationship between `level` and `filename_rule`. The comments explain the relationship between `level` and `filename_rule`, but it could be more explicit. Consider adding examples or a clearer explanation to help users understand how to configure these options correctly. --- `205-205`: Ensure `zip_enable` aligns with the project's security practices. Enabling zip compression for exported files can be convenient but ensure it aligns with the project's security and data handling practices, especially if sensitive data is involved. --- `212-212`: Validate the threshold for `at_least_image_count`. Ensure the threshold for `at_least_image_count` is set based on user feedback or analytics to optimize user experience and avoid skipping valuable content. --- `215-220`: Confirm compatibility of `j2p` plugin with image formats. The `j2p` plugin requires jpg images. Ensure there's clear documentation or checks in place to prevent user confusion if images are in a different format.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
---
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.