Closed hect0x7 closed 2 months ago
The update to JMComic version 2.5.10 enhances various aspects of the software. It includes improvements like updating version numbers, refining browser impersonation settings, optimizing plugin functionality for zip operations, and streamlining class methods for better file handling efficiency, especially in compression tasks.
File Path | Change Summary |
---|---|
src/jmcomic/__init__.py |
Version updated from '2.5.9' to '2.5.10'. |
src/jmcomic/jm_config.py src/jmcomic/jm_option.py |
- Updated new_postman function to use 'chrome110' . - Removed decide_album_dir method from JmOption class. |
src/jmcomic/jm_plugin.py |
Refactored zip_photo and zip_album methods to utilize dir_zip_dict for improved directory and zip file management. |
assets/docs/sources/option_file_syntax.md |
- Adjusted email_notify parameters.- Added guidance and warnings for zip plugin setup.- Updated settings for favorite_folder_export plugin.- Enhanced descriptions and prerequisites for j2p plugin. |
zip_photo
and zip_album
methods to enhance directory and zip file management directly addresses the reported issue where the zip plugin fails to identify the chapter path accurately during compression. This improvement aims to ensure the correct organization and compression of comic book files, aligning with the objective of the reported issue.🎉🐰📘
In the world of code, where the rabbits roam,
We tweaked and we twiddled, in our digital home.
With a hop and a skip, version two-five-one-oh,
Zip and compress, now smoother to go.
So here's to the changes, may they bring delight,
As we code through the day, and debug through the night.🥕🌟📚
assets/docs/sources/option_file_syntax.md (4)
`182-189`: Clarify the relationship between `level` and `filename_rule`. The comments explain the relationship between `level` and `filename_rule`, but it could be more explicit. Consider adding examples or a clearer explanation to help users understand how to configure these options correctly. --- `205-205`: Ensure `zip_enable` aligns with the project's security practices. Enabling zip compression for exported files can be convenient but ensure it aligns with the project's security and data handling practices, especially if sensitive data is involved. --- `212-212`: Validate the threshold for `at_least_image_count`. Ensure the threshold for `at_least_image_count` is set based on user feedback or analytics to optimize user experience and avoid skipping valuable content. --- `215-220`: Confirm compatibility of `j2p` plugin with image formats. The `j2p` plugin requires jpg images. Ensure there's clear documentation or checks in place to prevent user confusion if images are in a different format.
Summary by CodeRabbit
New Features
new_postman
function to impersonate Chrome 110 for improved compatibility.Refactor
Chores
Removed
decide_album_dir
method from options for streamlined configuration.