search

hectcastro / chef-collectd

A Chef cookbook to install collectd.
Apache License 2.0
23 stars 65 forks source link

Avoid memory issue if one of the write plugins is slow/unavailable (e.g. graphite) by limiting the queue size #52

Closed puckel closed 9 years ago

hectcastro commented 9 years ago

Thanks for the contribution, @puckel. I left a few comments, but otherwise these additions look good.

puckel commented 9 years ago

I've did the changes you mention. Previously, I did my change to respect rubocop/foodcritic from the last version of ChefDK

hectcastro commented 9 years ago

Ah, I have not done a good job of keeping up with all of the various code analysis tooling used by the Chef community.

I appreciate that you made these changes, and I opened https://github.com/hectcastro/chef-collectd/issues/55 to help get everything using the new syntax and tooling.