search

hectcastro / chef-collectd

A Chef cookbook to install collectd.
Apache License 2.0
23 stars 65 forks source link

Update write_graphite template #68

Closed emachnic closed 8 years ago

emachnic commented 8 years ago

According to the latest version of the "write_graphite" plugin, the <Carbon></Carbon> should now be <Node "example"></Node> (see https://collectd.org/wiki/index.php/Plugin:Write_Graphite). This PR updates the template to use the node hostname for the name of the write_graphite node.

hectcastro commented 8 years ago

Thanks for submitting this pull request, @emachnic. It looks like you're targeting master, but the base development branch is develop. Can you please retarget this PR against develop?

emachnic commented 8 years ago

@hectcastro Updated the base branch

hectcastro commented 8 years ago

Changes look good, but the commit history contains a bunch of commits from the master branch. It would be great if you could clean up the commit history to only contain the last two relevant commits.

One easy way to do that may be to create a new local branch based off of develop with just https://github.com/hectcastro/chef-collectd/pull/68/commits/4a6bdf70333f4fdb17760a78f4e5fefb13d8c177 and https://github.com/hectcastro/chef-collectd/pull/68/commits/2eaee0d2d4524a8f65ae25fe354551b3903a3a67 cherry-picked.