search

hector-client / hector

a high level client for cassandra
http://prettyprint.me/2010/02/23/hector-a-java-cassandra-client/
MIT License
644 stars 299 forks source link

Annotate m.p.c.connection.HConnectionManager#operateWithFailover #437

Open lewismc opened 12 years ago

lewismc commented 12 years ago

I've recently been trying to unravel a series of nasty stack traces which occour when running a test suite. HConnectionManager#operateWithFailover rears it's head towards the top of the stack, therefore when browsing the Hector code I noticed that although the method is pretty meaty, with a large catch block, there is very little Javadoc annotation. Once I get my around the method in my own context I would like to issue a pull request to you guys.

patricioe commented 12 years ago

Thanks Lewis for the feedback.

Is there any particular bug you are running into?

Sent from my Android On Mar 11, 2012 1:52 PM, "Lewis John McGibbney" < reply@reply.github.com> wrote:

I've recently been trying to unravel a series of nasty stack traces which occour when running a test suite. HConnectionManager#operateWithFailover rears it's head towards the top of the stack, therefore when browsing the Hector code I noticed that although the method is pretty meaty, with a large catch block, there is very little Javadoc annotation. Once I get my around the method in my own context I would like to issue a pull request to you guys.

Reply to this email directly or view it on GitHub: https://github.com/rantav/hector/issues/437

lewismc commented 12 years ago

Hi Patricioe, I'm not sure at this point if it's bug(s), my use of the API or whether I've configured the code properly to fit into out modular testing structure. I'll be hacking away at this, will definitely keep this issue and discussion up to date, certainly annotate the method of concern, and hopefully bottom out some other things along the way...(now I can exhale :0))

patricioe commented 12 years ago

Lewis, feel free to email me either here or in a private channel the exceptions you ran into. They may be known ones and perhaps I could be able to point what causes them.

Sent from my Android On Mar 11, 2012 3:01 PM, "Lewis John McGibbney" < reply@reply.github.com> wrote:

Hi Patricioe, I'm not sure at this point if it's bug(s), my use of the API or whether I've configured the code properly to fit into out modular testing structure. I'll be hacking away at this, will definitely keep this issue and discussion up to date, certainly annotate the method of concern, and hopefully bottom out some other things along the way...(now I can exhale :0))

Reply to this email directly or view it on GitHub: https://github.com/rantav/hector/issues/437#issuecomment-4442670