comments

[hectoronevu]

I'll try to get comments to work if no one volunteers, we need someone to work on the look of the texts, the background is great though.

[hectoronevu]

I managed to get some comments functionality to work, but there's a bug in my comments.php where $postID is giving out warnings and showing all comments instead of those sharing the same $postID

[hectoronevu]

other features to be worked on are delete, edit comments and posts.

[bmacc]

I posted some updates to comments.php and index.css. I also added a new file, commentsII.php to go along with them. Download and check them out, let me know why you think. Keep in mind though that posting a comment screws the whole layout up since the posting of comments is not fully working yet. On Jul 21, 2013, at 1:36 PM, hectoronevu notifications@github.com<mailto:notifications@github.com> wrote:

other features to be worked on are delete, edit comments and posts.

— Reply to this email directly or view it on GitHubhttps://github.com/hectoronevu/blog/issues/6#issuecomment-21313663.

[hectoronevu]

got comments to work, however style.css causes the form data to be unselectable, so using styles.css for now. I suspect this will hold true for whatever pages that has a form and use style.css

http://stackoverflow.com/questions/9073136/html-form-input-not-selectable

[bmacc]

I don't have any style.css. I'm only using styles.css. Also, I just update styles.css on github. Download it and check if it works. On Jul 22, 2013, at 12:43 AM, hectoronevu notifications@github.com<mailto:notifications@github.com> wrote:

got comments to work, however style.css causes the form data to be unselectable, so using styles.css for now. I suspect this will hold true for whatever pages that has a form and use style.css

http://stackoverflow.com/questions/9073136/html-form-input-not-selectable

— Reply to this email directly or view it on GitHubhttps://github.com/hectoronevu/blog/issues/6#issuecomment-21324567.

[bmacc]

nevermind. mines is called styles.css, how the one on github is style.css. On Jul 22, 2013, at 12:43 AM, hectoronevu notifications@github.com<mailto:notifications@github.com> wrote:

got comments to work, however style.css causes the form data to be unselectable, so using styles.css for now. I suspect this will hold true for whatever pages that has a form and use style.css

http://stackoverflow.com/questions/9073136/html-form-input-not-selectable

— Reply to this email directly or view it on GitHubhttps://github.com/hectoronevu/blog/issues/6#issuecomment-21324567.

[hectoronevu]

let me know when you think it works, the combined one.

[bmacc]

upload the updated comments.php and I'll check it with what I got On Jul 22, 2013, at 12:50 AM, hectoronevu notifications@github.com<mailto:notifications@github.com> wrote:

let me know when you think it works, the combined one.

— Reply to this email directly or view it on GitHubhttps://github.com/hectoronevu/blog/issues/6#issuecomment-21324702.

[hectoronevu]

wait, you mean download the version I uploaded 13min ago right?

[bmacc]

opps, haven't notice. Is there a way to sort the list by recently updated? On Jul 22, 2013, at 12:55 AM, hectoronevu notifications@github.com<mailto:notifications@github.com> wrote:

wait, you mean download the version I uploaded 13min ago right?

— Reply to this email directly or view it on GitHubhttps://github.com/hectoronevu/blog/issues/6#issuecomment-21324808.

[hectoronevu]

Hmm, I'm not an expert but maybe if you were to click on "58 commits" near the top, it will show you a sorted list with the most recent commits at the top.

[hectoronevu]

Brian, I don't think commentsII.php will work because in there is $_GET['postID'], which was what was bugging us out last time. Notice in comments.php I do if(isset($_GET['postID'])), that tests if that variable has a value, if it does I assign it to $postID and if it does not, I assign $postID = $_POST['postID'];

[bmacc]

Nice catch. I'm looking into it. On Jul 22, 2013, at 1:41 AM, hectoronevu notifications@github.com<mailto:notifications@github.com> wrote:

Brian, I don't think commentsII.php will work because in there is $_GET['postID'], which was what was bugging us out last time. Notice in comments.php I do if(isset($_GET['postID'])), that tests if that variable has a value, if it does I assign it to $postID and if it does not, I assign $postID = $_POST['postID'];

— Reply to this email directly or view it on GitHubhttps://github.com/hectoronevu/blog/issues/6#issuecomment-21325622.

[bmacc]

I believe it should work now. I was unaware that you changed the $_GET and a few variables. That portion that was changed in comments.php, should have been changed in commentsII.php, since comments.php is pulling that specific code from commentsII.php On Jul 22, 2013, at 1:41 AM, hectoronevu notifications@github.com<mailto:notifications@github.com> wrote:

Brian, I don't think commentsII.php will work because in there is $_GET['postID'], which was what was bugging us out last time. Notice in comments.php I do if(isset($_GET['postID'])), that tests if that variable has a value, if it does I assign it to $postID and if it does not, I assign $postID = $_POST['postID'];

— Reply to this email directly or view it on GitHubhttps://github.com/hectoronevu/blog/issues/6#issuecomment-21325622.

[hectoronevu]

The problem is that in comments.php, the important $postID is used after commentsII.php is run, and commentsII.php is calling $_GET['postID'] inside which will fail after the form in comments.php is submitted. It's a simple fix of copying the $postID code into commentsII.php and replacing $_Get['postID'] with it after it is defined.

[bmacc]

I already that. And post the update version On Jul 22, 2013, at 1:59 AM, hectoronevu notifications@github.com<mailto:notifications@github.com> wrote:

The problem is that in comments.php, the important $postID is used after commentsII.php is run, and commentsII.php is calling $_GET['postID'] inside which will fail after the form in comments.php is submitted. It's a simple fix of copying the $postID code into commentsII.php and replacing $_Get['postID'] with it after it is defined.

— Reply to this email directly or view it on GitHubhttps://github.com/hectoronevu/blog/issues/6#issuecomment-21325984.