hed-standard / hed-schemas

Repository for HED schemas. The SCORE library for clinical annotations is now available.
https://hed-schemas.readthedocs.io/en/latest/
Creative Commons Attribution 4.0 International
1 stars 11 forks source link

SCORE Artificat class potential blockage #138

Closed VisLab closed 6 months ago

VisLab commented 7 months ago

I propose that since going forward SCORE will always be partnered, that in SCORE 2.0.0 we move the hierarchy

Artifact to the standard schema as:

Data-property/Data-artifact-type

and move the major categories of artifact to the standard schema:

Data-property/Data-artifact-type/Biological-artifact Data-property/Data-artifact-type/Non-biological-artifact Data-property/Data-artifact-type/Other-artifact

We may want to move a few of the other items that currently appear under that to the standard schema as well. We have an opportunity to do this now with the upcoming release of a major backwards incompatible version of SCORE.

Reasoning: If they stay in SCORE, then anyone who wants to add an artifact type to SCORE will have to add it to SCORE rather than to its own library. If at least the top-level stuff is moved --- SCORE can anchor its specific artifacts in the standard schema but other libraries can add their own artifacts independently. I think this will be a very relevant issue for the upcoming development of a MOBI schema.

@dorahermes @smakeig @neuromechanist @christinerogers @monique2208

dorahermes commented 7 months ago

I agree that there are benefits to this and don’t see any major cons.

The only thing to note is that some of the SCORE artifacts are specific to ephys data, and MRI data have different artifacts (eg ringing, Eddy etc), so we should consider that in the hierarchy.

VisLab commented 7 months ago

I think we should just add the high levels as listed above and have SCORE anchor to those. That way different modalities can put own and not conflict with or have to include SCORE... However maybe we only want to put Data-property/Data-artifact-type in the standard schema and then let individual schema modalities (such as the upcoming MOBI schema) organize their own hierarchy of artifacts and not conflict with anything or be forced to include unrelated libraries.

dorahermes commented 7 months ago

Per discussion with @monique2208 the non-biological-artifact category is an exclusive category that does not make sense from an ontological perspective.

We have 2 options:

1) Group the non-biological artifacts directly under artifact 2) We can create other sub-categories, such as

We agreed that 1) would be the best for now.

VisLab commented 6 months ago

Addressed in PR #140

dorahermes commented 6 months ago

It seem like this issue had been resolved and can be closed?

VisLab commented 6 months ago

This is now being handled in issue #144