search

hed-standard / hed-schemas

Repository for HED schemas. The SCORE library for clinical annotations is now available.
https://hed-schemas.readthedocs.io/en/latest/
Creative Commons Attribution 4.0 International
1 stars 11 forks source link

Fixed the XML for the testlib #154

Closed VisLab closed 7 months ago

VisLab commented 7 months ago

Note: The current version of the prelease of 8.3.0 does not validate because we are in the process of adding allowedCharacter support. A subsequent pull request will fix this @IanCa.

IanCa commented 7 months ago

It would probably be best to put it on the unit only rather than the unitClass or both? When validating it's just going to check if the default unit exists or not, it won't care at that point if it has invalid characters. It will check the invalid characters on the actual unit.

Also just to note, this is a new case where "allowedCharacter" will now have a direct impact on a schema, rather than just normal validation of value classes. This isn't a problem for me, just confirming intent.

IanCa commented 7 months ago

Validation is failing because allowedCharacter is only applicable to value classes(in the current 8.3.0), but used on units and unit classes.