search

hed-standard / hed-schemas

Repository for HED schemas. The SCORE library for clinical annotations is now available.
https://hed-schemas.readthedocs.io/en/latest/
Creative Commons Attribution 4.0 International
1 stars 11 forks source link

Refactor body parts hierarchy on 8.2.0 mediawiki #167

Closed neuromechanist closed 4 months ago

neuromechanist commented 4 months ago

Following the discussion in #164, these changes will add a couple of terms and lightly adjust the anatomical hierarchy.

This pull request will close #164.

VisLab commented 4 months ago

I think we have to modify the schema under Body-part to preserve the is-a relationship. This will involve adding additional x-part organizational tags. Because annotators mainly look for tags not paths, I don't think this will be a burden. We can put additional links in the ontology representation and create alternative hierarchical paths.

@smakeig @monique2208 @neuromechanist @dorahermes @dungscout96 : As a reminder we already had this discussion in the transition from HED2 to HED3. HED2 had a mixed hierarchy with has-a and is-a relationships intermixed. We had a schema attribute predicateType to distinguish. It made things very difficult. We agreed to go with strict is-a to clean up the schema and assure search generality. We removed the predicateType schema attribute. I know this is annoying not to have the parts.....

* predicateType <nowiki> [One of propertyOf, subclassOf, passThrough -- used to facilitate mapping to OWL or RDF.]</nowiki>

One thing that we could do is to introduce an isPartOf schema attribute that works like suggestedTag. This would inherited and would alert users about the relationship. What do you think? @smakeig this might partially address your suggestion. This attribute might be useful for the language schema also and can be translated directly into the HED ontology.

neuromechanist commented 4 months ago

I'll close this PR and open another one based on the Pre-release Schema.