search

hed-standard / hed-schemas

Repository for HED schemas. The SCORE library for clinical annotations is now available.
https://hed-schemas.readthedocs.io/en/latest/
Creative Commons Attribution 4.0 International
1 stars 11 forks source link

<property> tags used instead of <attribute> #168

Closed dungscout96 closed 6 months ago

dungscout96 commented 6 months ago

The (legacy?) <property> tags were used instead of <attribute> for schemaAttributeDefinitions: https://github.com/hed-standard/hed-schemas/blob/bd30aa1035baa6770913880a1b9d2c5dd5c5735e/standard_schema/hedxml/HED8.2.0.xml#L7040

The schema viewer thus unable to parse these fields to display.

IanCa commented 6 months ago

Is this not correct? I have no issue changing the converter if told to, but it's been like this a while.

The viewer can treat them the same as attributes in most senses, that's what the hed-python code does.

https://hed-specification.readthedocs.io/en/develop/03_HED_formats.html#xml-schema-format

VisLab commented 6 months ago

<property> is correct. The property section has modifiers of the schema attributes themselves. They are distinctly different. It has always been this way.

It is necessary to call them something different because they are semantically different. In the ontology representation: tag, unit, unit class, value class, unit modifier are all OWL classes. Schema attributes translate to DataProperty, ObjectProperty, or AnnotationProperty. That is, schema attributes are functions with domains and ranges.

The <property> section specifies the domain, range, and inheritance characteristics of the attributes. These <property> values are necessary and sufficient to determine what kind of OWL Property a HED schema attribute is. In other words --- the <property> section has to be distinguished from schema attributes.

dungscout96 commented 6 months ago

I see, sorry for the misunderstanding. I updated the schema browser accordingly. It should display the properties now.