search

hed-standard / hed-schemas

Repository for HED schemas. The SCORE library for clinical annotations is now available.
https://hed-schemas.readthedocs.io/en/latest/
Creative Commons Attribution 4.0 International
1 stars 11 forks source link

Anatomy reorganization #174

Closed neuromechanist closed 5 months ago

neuromechanist commented 6 months ago

Following the attempted PR #167 and issue #164, this current PR includes the changes in the hierarchy under the latest Schema 8.3.0.

The HED IDs are set to 0000000 to pass the validators. The MediaWiki and XML passed Validator and the difference between 8.3.0 and the current pull request of 8.3.0 is summarized in the text file.

VisLab commented 6 months ago

@neuromechanist sorry for the confusion, but could you completely remove hedId=HED_0000000. The hedId should be omitted completely for new nodes.

neuromechanist commented 6 months ago

@neuromechanist sorry for the confusion, but could you completely remove hedId=HED_0000000. The hedId should be omitted completely for new nodes.

Of course, they are removed.

neuromechanist commented 6 months ago

Thanks for removing the head. I have some questions about anatomy. The elbow does not seem to be part of the forearm and the wrist does not seem to be part of the hand, but the ankle seems to be part of the foot according to wikipedia. Confusing....

Joints are usually a point of debate. What we see/feel is generally the end of the bones making the joint. I don't (currently) think the joints can be independent entities under the upstream node. For example, Elbow can't be directly under the Upper-extremity-part; it should be either under Upper-arm-part or Forearm-part.

To have a consistent hierarchy, I put the proximal (that is, closer to the body core) joint under each node. Therefore, Shoulder is under Upper-arm-part, Elbow is under Forearm-part and Writst is under Hand-part.