search

hedefalk / atom-vue

Vue component file syntax for Atom
Other
147 stars 38 forks source link

Autocomplete of Sass is broken #46

Closed resse92 closed 6 years ago

resse92 commented 7 years ago

I just use l<style lang="sass">, there is no hint about property hint? image

aidistan commented 7 years ago

The issue has no relation to atom-vue and atom-vue does not provide any hint function.

It seems like that the SASS atom package you used could not handle the situation well.

tuurbo commented 7 years ago

@zhuruliang Did you ever find an alternative way to get property hints?

inssitu commented 7 years ago

Hi @aidistan you know any solution for this?

aidistan commented 7 years ago

Hi @inssitu. This issue is caused by the official package autocomplete-css which fails to recognize the SASS scope (named source.sass.embedded.html) in Vue.

Related lines are:

If you want this feature badly, you could hack atom-vue by changing this line to name: "source.sass". Though it's not recommended to do this, since it violates the scope naming convention.

This is as far as I could help. I write SCSS more often actually. Good luck!

aidistan commented 7 years ago

I will keep this issue open and update it according to the progress in atom/autocomplete-css#98

aidistan commented 7 years ago

My PR atom/autocomplete-css#99 has been merged. Since that's a core package, let's wait the next release version of Atom to fix this.

corysimmons commented 7 years ago

@aidistan Any update on this? Seems like https://github.com/atom/atom/releases/tag/v1.18.0 hit on June 15.

Would looooveee some autocomplete (and maybe even Emmet?) on <style lang="scss"> 😍

aidistan commented 7 years ago

@corysimmons It seems like Atom v1.180 was still packed with autocomplete-css v0.16.2 which does not include my PR.

I would love any autocomplete, but maybe it's more suitable to put them in the language-scss package?

corysimmons commented 7 years ago

🤷‍♂️

kingsleydon commented 7 years ago

Atom 1.19.0 release was still packed with autocomplete-css v0.16.2.😓 I try using apm install https://github.com/atom/autocomplete-css.git to install the latest version (now v0.17.2) from git repo and now autocomplete on <style lang="sass"> works well! screen shot 2017-08-09 at 20 52 01 screen shot 2017-08-09 at 20 52 55

aidistan commented 7 years ago

@Kingsley-Don Coooool! I have found that Atom v.1.20.0-beta0 is packed with autocomplete-css v0.17.2. Let's wait the official release~

aidistan commented 6 years ago

Already published in v1.20.0