hedgedoc / container

HedgeDoc container image resources
https://docs.hedgedoc.org/setup/docker/
195 stars 52 forks source link

Consider hardcoding GID alongside UID for image user? #462

Open decentral1se opened 1 year ago

decentral1se commented 1 year ago

https://github.com/hedgedoc/container/blob/cb6d7c99b2c63757900ce6a0156c731a9528d15b/debian/Dockerfile#L57

It's cool that you're doing this!

However, due to an open issue in Docker (https://github.com/moby/moby/issues/2259) we need to chown the volume from the host machine to match user permissions. This is fine but because you did not hardcode the GID also, it changes on each deployment? This means we can't write scripts that do this automatically because the GID value is changing.

See https://github.com/mastodon/mastodon/blob/74903af7ce6a0622752e19b1e0b326ecfa0463cb/Dockerfile#L48-L49 for an approach which sets both.

This allows us to write scripts chown $UID:$GID ... and not have it change in between deployments.