search

hedgedoc / react-client

The frontend of the upcoming version 2.0
https://hedgedoc.dev
GNU Affero General Public License v3.0
104 stars 13 forks source link

Dark Mode in 2.0 fails in Firefox #2502

Closed mcnesium closed 1 year ago

mcnesium commented 2 years ago

Follow-up of https://github.com/hedgedoc/react-client/issues/1235#issuecomment-1297106954:

Unfortunately the new dark mode introduced in #2448 doesn't seem to work well in Firefox 106 on Gnome Desktop:

Screencast from 08.11.2022 17:36:27.webm

At 0:28 I switch to light theme and back to dark at 0:32.

Please suggest how I can provide more helpful information.

mrdrogdrog commented 2 years ago

It does work, but the preferred setting is read once at the start of the app.

mrdrogdrog commented 2 years ago

(at least it does that right now. I guess we never thought about syncing the color scheme after the app has been initialized😅)

mrdrogdrog commented 1 year ago

Has been solved with 4e18ce38f3bfe9571ebf2a203010522cf3576768 . Should already be deployed on hedgedoc.dev