hedgehogqa / fsharp-hedgehog

Release with confidence, state-of-the-art property testing for .NET.
https://hedgehogqa.github.io/fsharp-hedgehog/
Other
272 stars 30 forks source link

Change .NET runtime targets to current recommendations #416

Closed LyndonGingerich closed 2 years ago

LyndonGingerich commented 2 years ago

Solves #411.

These two warnings remain:

  NuGet.Build.Tasks.Pack.targets(221, 5): [NU5125] The 'licenseUrl' element will be deprecated. Consider using the 'license' element instead.
  NuGet.Build.Tasks.Pack.targets(221, 5): [NU5048] The 'PackageIconUrl'/'iconUrl' element is deprecated. Consider using the 'PackageIcon'/'icon' element instead. Learn more at https://aka.ms/deprecateIconUrl
dharmaturtle commented 2 years ago

I'm a little busy this weekend so I'm not sure when I can give this more thought, but we wanna be careful when touching Fsharp.Core:

Targeting an earlier version of FSharp.Core increases your reach because older codebases can use it without issue

https://fsharp.github.io/fsharp-compiler-docs/fsharp-core-notes.html

I think it's reasonable to upgrade to 4.3.4, and I think that still solves #411, but haven't been able to thoroughly test it.

TysonMN commented 2 years ago

This build says

Passed! - Failed: 0, Passed: 153, Skipped: 0, Total: 153, Duration: 239 ms - Hedgehog.Linq.Tests.dll (net6.0) but I only see 18 tests locally.

Why is that?

TysonMN commented 2 years ago

I think it's reasonable to upgrade to 4.3.4, and I think that still solves #411, but haven't been able to thoroughly test it.

4.3.4 worked, so I used that.

TysonMN commented 2 years ago

I wasn't planning on getting this merged tonight, but my initial attempt to release version 0.13.0 failed. I had recently updated to the latest (fork) version of the NuGet publishing GitHub action. In hindsight, I should have not made that change until this code was merged. Of course I could have reverted that change, but who wants to go backwards in life? Not me.

moodmosaic commented 2 years ago

This build says

Passed! - Failed: 0, Passed: 153, Skipped: 0, Total: 153, Duration: 239 ms - Hedgehog.Linq.Tests.dll (net6.0) but I only see 18 tests locally.

Why is that?

Could it be the same tests are parameterized?

TysonMN commented 2 years ago

Could it be the same tests are parameterized?

Yes, that it is. There are 18 tests, but one has 136 parameters, and 18 - 1 + 136 = 153.

2022-08-28_14-50-56_713_devenv