Closed ryzheboka closed 1 year ago
Totals | |
---|---|
Change from base Build 3400309470: | 0.0% |
Covered Lines: | 735 |
Relevant Lines: | 735 |
Thanks for a fast review! I added your suggested changes and pushed them.
build:
go build -o ./bin/generate/rex ./cmd/generator/main.go
Thanks for a fast review! I added your suggested changes and pushed them.
- Is following addition to the Makefile ok?
build: go build -o ./bin/generate/rex ./cmd/generator/main.go
- Thanks, that's way more practical than pushing each time
- How do you mean: "I think we don't handle the escape character (" ?
- I am not sure about how to use the parser. Do you mean creating a *Regexp first, and then generating the code?
- Thank you for your answers! It's a great learning experience for me :)
\(#\d+\)
. \(
indicates the symbol (
, not starting of the group.Your suggestions are pushed :)
The PR is adjusted according to comments :) There should be no duplicates now
The PR is related to #13. To run the script, execute
In the generator folder. Then run following command with the regex of your choice: