MathieuVeber
commented
5 months ago i really really like it!
my only question is: is it a bit excessive to spin up so many github action runners, setup node and install dependencies in each of them?
i think especially lint & format, i am so glad you've included them, and it is cool that they can run in parallel, but they don't take very long, and so maybe they should just be a part of the build workflow, and it fails if they fail.
alternatively you could look into caching artifacts, but i'm not sure how useful that would be.
anyway, that was just some thoughts.
For sure it's not really about Github Action time optimisation (nor cost optimisation) but I've been there before and when you want to deploy and test something quickly and you first have to fix the lint before you realize that it doesn't even build it can get really annoying... So this is more for our own time and mental health than for Github I would say!
Also you might have not noticed but I've added cache in each action exactly to avoid fetching dependencies every time 😉
Examples: