search

hedia-team / .github

0 stars 0 forks source link

feat(workflows): add `approve-please` #42

Closed MathieuVeber closed 2 months ago

aimeerivers commented 2 months ago

wait, will this even be possible?

the kinds of PRs we want to auto approve are those raised by bots. can a bot approve their own PR? do we need two bots, one to open and one to close?

MathieuVeber commented 2 months ago

amazing, i love it!

have you checked what happens if a PR is missing some required checks? i presume gh pr review --approve will fail, but is it clear why?

Approve doesn't mean merge so it shouldn't fail 🙂

MathieuVeber commented 2 months ago

wait, will this even be possible?

the kinds of PRs we want to auto approve are those raised by bots. can a bot approve their own PR? do we need two bots, one to open and one to close?

Wait you're right! A PR cannot be approve by its author, I guess this cannot work then...

aimeerivers commented 2 months ago

Wait you're right! A PR cannot be approve by its author, I guess this cannot work then...

what is hedia-bot-limited? i saw that mentioned in the options. is that another bot we can use for the approvals?

aimeerivers commented 2 months ago

if it helps, this is how i find and approve hedia-bot PRs as myself ... there might be some tricks in there you can use.

https://github.com/hedia-team/update-repos/blob/main/merge-prs.sh

MathieuVeber commented 2 months ago

Wait you're right! A PR cannot be approve by its author, I guess this cannot work then...

what is hedia-bot-limited? i saw that mentioned in the options. is that another bot we can use for the approvals?

I think it's one bot that is used with the translations thing (at least it's part of the translators team) but it could be also that it's just a convenient bot with restricted permissions... :shrug:

It's worth giving it a try, let try to use hedia-bot or hedia-bot-limited depending on the need

MathieuVeber commented 2 months ago

if it helps, this is how i find and approve hedia-bot PRs as myself ... there might be some tricks in there you can use.

https://github.com/hedia-team/update-repos/blob/main/merge-prs.sh

Thanks but since you are "yourself" everything just works and there is no way I will use a PAT from each of us depending on the actor... It needs to be smarter!

aimeerivers commented 2 months ago

oooo, smart choosing of which bot to use, i like it!

aimeerivers commented 2 months ago

there is no way I will use a PAT from each of us

no, i agree, that would be a terrible idea!!