search

hedib / Quiz-app

0 stars 0 forks source link

Feedback on final #2

Open barryross opened 8 years ago

barryross commented 8 years ago

FEWD Final Project

Description

For the final project, you'll be designing and building a website of your choice. This project will test your knowledge of front-end web development and ask you to apply everything you've learned in this course. The result will be a website that you can add to your portfolio. You could create: a portfolio website; a marketing website for a startup or business; or a prototype for a simple web-app. Work with your instructor and EIR's to create project goals that are realistic given the scope and timing of the class.

Student: Hediyeh Ledbetter

Project URL: https://github.com/hedib/Quiz-app
Technical Requirements Does Not Meet Expectations (0) Meets Expectations (1) Exceeds Expectations (2)
Project Proposal / Wireframes turned in week 5 x
Draft of HTML/CSS turned in week 7 x
First draft of JS turned in week 8 x
Updated rough draft of project week 9 x
Final presentation x
Use HTML5 structural elements (header, footer, nav, footer) x
Demonstrate a correct use of classes and IDs x
Use classes to identify a type of element and IDs for identifying a specific unique element on the page x
Select the appropriate tags to markup content x
Apply fonts, color and styles to elements and the page x
Demonstrate use of floats (or inline-block) and the box model x
Use JavaScript/jQuery to make pages interactive x
TOTAL: 21/24
barryross commented 8 years ago

Hey Hedi, I now realize I only got written feedback off to you guys, but not the rubric for the final! Apologies for the delay on this, but here you go. Overall, awesome work with this.

There were some spots where it seemed like classes were used on unique elements and vice versa, for example .my-slides and .my-slides1 could use IDs if they are unique items/have unique styling requirements. One thing I noticed was an

tag being used in a place which doesn't really seem like content that would be "on its own"

Overall though, great use of HTML5 tags. The only other point I left off was for floats, b/c I notice you used a fixed height in some circumstances where I think overflow:hidden would have helped compensate for the use of float.

Great work though!