search

hediet / browser-ext-github-monaco

This extension brings the famous Monaco editor to Github
https://chrome.google.com/webstore/detail/monaco-markdown-editor-fo/mmpbdjdnmhgkpligeniippcgfmkgkpnf?hl=de&authuser=0
259 stars 32 forks source link

Improve Completion Of Gemojis #10

Closed hediet closed 3 years ago

hediet commented 3 years ago

At this cursor position, Gemoji completion should not be triggered:

foo:|
joaomoreno commented 3 years ago

Oh yeah. I hit this all the time. I really like that the auto suggestion box comes up... unless I'm actually ending a line with : and pressing Enter for a new paragraph. Apparently I do this a lot. 😆

Maybe we could have it automatically come up if the user presses : and a letter? I wonder if we even support that.

Or perhaps we can just have :\n be the default suggestion such that pressing Enter will accept it and insert a new line.

hediet commented 3 years ago

Yes, I need to fix this asap :D I'm using ":" quite often too in non-smiley contexts.

I wonder if we even support that.

You do ;) There is a command to trigger the suggestion box. So ":" should be disabled as a trigger character and the suggestion box should be triggered by code on text change.

Or perhaps we can just have :\n be the default suggestion such that pressing Enter will accept it and insert a new line.

I think the suggestion box for smileys should only come up if you actually intend to insert a smiley.

joaomoreno commented 3 years ago

fast

hediet commented 3 years ago

Maybe we could have it automatically come up if the user presses : and a letter? I wonder if we even support that.

Actually, all it need for showing the box automatically after typing : and a letter was 150e1262e9d3aaf8bed80944e14161534ae27851 :D I don't know why though. Apparently Monaco uses Magicâ„¢.