search

hediet / browser-ext-github-monaco

This extension brings the famous Monaco editor to Github
https://chrome.google.com/webstore/detail/monaco-markdown-editor-fo/mmpbdjdnmhgkpligeniippcgfmkgkpnf?hl=de&authuser=0
259 stars 32 forks source link

Tab title changes to "(Draft comment)" when comment box is empty #36

Open tech189 opened 2 years ago

tech189 commented 2 years ago

If you leave an issue or pull request page open in the background, the tab title will immediately change to "(Draft comment) ..." even if the user hasn't typed anything in the comment box.

This does not happen when the addon is disabled.

fregante commented 1 year ago

Note that this is due to Refined GitHub (but won't be fixed there since it's due to an external cause)

https://github.com/refined-github/refined-github/blob/main/source/features/unfinished-comments.tsx

hediet commented 1 year ago

@fregante is this extension the external cause? Do you know why this happens?

fregante commented 1 year ago

This is the condition that determines whether there's a "draft comment":

https://github.com/refined-github/refined-github/blob/1cef9d43cc5990c6aed55b01508297b347c8a261/source/features/unfinished-comments.tsx#L14

I don't know exactly what part of Monaco is causing that condition to become true