hediet / browser-ext-github-monaco

This extension brings the famous Monaco editor to Github
https://chrome.google.com/webstore/detail/monaco-markdown-editor-fo/mmpbdjdnmhgkpligeniippcgfmkgkpnf?hl=de&authuser=0
257 stars 32 forks source link

Editor height should have a soft limit #4

Closed joaomoreno closed 3 years ago

joaomoreno commented 3 years ago

When editing a large comment post or wiki page, the editor takes the same height as its content. This is problematic because the users can't scroll inside the editor area, not can they click and drag text selection to scroll down.

I suggest to just cap the editor widget height, like GH normally does. What do you think?

recording (2)

hediet commented 3 years ago

I suggest to just cap the editor widget height, like GH normally does. What do you think?

A good idea! Should be easy to implement, I will have a look in the next days. At first it was kind of a feature, but I totally see why it does not make sense in your case. Maybe a setting would make sense here.

hediet commented 3 years ago

There is a soft limit of 400px now: image

I also added a full screen (aka zen) mode that can be toggled with F11: image

joaomoreno commented 3 years ago

That is fantastic! Definitely gonna demo this in today's standup! 👏

hediet commented 3 years ago

That is fantastic! Definitely gonna demo this in today's standup! 👏

Thanks, I hope they liked it 😊