hediet / vscode-drawio

This unofficial extension integrates Draw.io (also known as diagrams.net) into VS Code.

https://marketplace.visualstudio.com/items?itemName=hediet.vscode-drawio

GNU General Public License v3.0

9.09k stars 414 forks source link

Standard BPMN 2.0 Shapes fail to load #238

Closed LRelar closed 1 year ago

LRelar commented 3 years ago

+More Shapes->Business->BPMN 2.0 These shapes fail to load its group contents when trying to expand group. The behavior depends on order you attempt to expand the group. Trying to open BPMN 2.0 Tasks or BPMN 2.0 Choreographies foremost corrupts whole BPMN 2.0 Shapes set.

anderskristian commented 3 years ago

This is exactly the problem that let me investigate drawio - and found out that there is a problem in this implementation

I don't have any clue on how identical these parts are in code version and https://github.com/jgraph/drawio
Is it a question of copying some directories with graphical elements and rebuild?
I also see that the menu system is not identical - still I got no clue weather this is necessary to be different or it just happened

hediet commented 3 years ago

I don't have any clue on how identical these parts are in code version and https://github.com/jgraph/drawio

They should be identical. See the submodule drawio in https://github.com/hediet/vscode-drawio.

I also see that the menu system is not identical - still I got no clue weather this is necessary to be different or it just happened

I had to remove dysfunctional menu items (such as print etc.).

If more people run into this particular issue, I will do a more depth investigation.

anderskristian commented 3 years ago

Now I have "learned a little of how to build" - and it seems that elements are added as git submodules It is a little strange that BPMN 2.0 is not in 1.6.6

Does the project miss a script to get the correct git submodules ???

DanielTheCoder commented 3 years ago

Repro Steps

I've the same issue that BPMN 2.0 Shapes are missing when

using vscode v1.58.2 (user setup)
using extension v1.6.1.
using Vscode-drawio: Offline mode => checked

missing shapes:

Output from development console inside vscode:

Workaround

If I'm switching to online mode, it seems working so far

using Vscode-drawio: Offline mode => unchecked

shapes are present

Hope details will help ...

niritum commented 3 years ago

Not only bpmn. I don't use draw.io to draw simple diagrams (in strictly defined notations only). Archimate 3.1 and other libraries don't work either. Also, adding a new library can break the display of an existing library. It will be very cool if you can fix everything )

BartNetJS commented 2 years ago

Any update on this issue? Would be cool if fixed. Great tool!

hediet commented 2 years ago

No updates, but will look into it soon!

hediet commented 1 year ago

Duplicate of #354. Should be fixed in the insider version.