hediet / vscode-drawio

This unofficial extension integrates Draw.io (also known as diagrams.net) into VS Code.
https://marketplace.visualstudio.com/items?itemName=hediet.vscode-drawio
GNU General Public License v3.0
9.1k stars 416 forks source link

Feature request: match theme colors #4

Open onlyafly opened 4 years ago

onlyafly commented 4 years ago

Great extension. It just works :)

As you can see below, the colors of the extension don't match the theme colors. It would be awesome if it did!

Screen Shot 2020-05-10 at 18 11 33
hediet commented 4 years ago

I tried to match at least the dark/light-mode. However, there seems to be a bug in VS Code that prevents that.

However, matching the actual colors is a daunting (but not impossible) task. I don't think I'm going to implement that by myself but I'm open for contributions!

EntilZha commented 4 years ago

Would it be possible to make light/dark configurable? I use dark mode for my editor, but want to see how my figure would appear against white background since my figure will eventually be on a white background.

Fr33maan commented 4 years ago

Or maybe just use the drawio themes ?

hediet commented 4 years ago

There is a config option now in v0.3.0. This option lets you choose a Draw.io theme independently of VS Code's active theme.

MaxymVlasov commented 4 years ago

For set light theme, add in your settings.json next:

    "hediet.vscode-drawio.theme": "atlas"
    // or if you'd like white menu on the top, not blue, use "Kennedy" theme
    "hediet.vscode-drawio.theme": "Kennedy"
    // or if you mostly view, not edit, use "minimal" theme 
    "hediet.vscode-drawio.theme": "min"

Dark:

    "hediet.vscode-drawio.theme": "dark"
Screenshot Examples (click to show)
  • atlas: atlas
  • Kennedy: Kennedy
  • min: min
  • dark: dark

Possible values: https://github.com/hediet/vscode-drawio/blob/6d8bba36feb0fc1039e89571f32ee3e969f7f579/package.json#L85-L89

EntilZha commented 4 years ago

The settings are a great solution, imho matching theme colors would be overkill