Upgrade processors to Monolog 3 and fixe issue in RenameIdFieldProcessor

hedii / laravel-gelf-logger

A package to send gelf logs to a gelf compatible backend like graylog

MIT License

125 stars 33 forks source link

Closed patriziotomato closed 1 year ago

patriziotomato commented 1 year ago

Upgrade processors to Monolog 3
Fix issue in RenameIdFieldProcessor having both _id and id field which don't remove the id field

hedii commented 1 year ago

@patriziotomato thanks!

patriziotomato commented 1 year ago

@hedii Any idea why the tests did not fail before?

hedii commented 1 year ago

because:

in ProcessorTest we only test for class being added to the handler
in NullStringProcessor and RenameIdFieldProcessor we only test for what what these classes are returning

These tests are not enough, they need to be updated