Closed doupongzeng closed 10 months ago
Yes--to make sure I'm on the same page, you're running an old version of Bazel < 6.1 where our passing host_features breaks things, yes?
If you can't just update, would you be down to toss up a PR so we call bazel version
from inside the python script and parse it and use that to gate the addition of the flag, and make sure all still works for you?
Preferably with a fn just above _get_compile_commands_for_aquery like:
@functools.lru_cache(maxsize=None)
def _get_bazel_version():
subprocess.run(
...
return <version tuple>
@doupongzeng, how much do you need the old version? We're thinking about whether we need to support 6.1 in another feature, #154
@doupongzeng, how much do you need the old version? We're thinking about whether we need to support 6.1 in another feature, #154
I am currently using version 5.1.0, and I have temporarily removed the --host_features=compiler_param_file
, which also works.
I understand. Is upgrading an option? And if not, would you be down to toss up a PR as above, and chime in on #154 asking for backwards compatibility? He'll know what you mean.
I understand. Is upgrading an option? And if not, would you be down to toss up a PR as above, and chime in on #154 asking for backwards compatibility? He'll know what you mean.
Sure, I can try this weekend. Upgrading the version seems infeasible right now.
[6.1.0] Add --host_features
I think it's possible to add a version number check during execution; otherwise, error messages can be confusing and unclear at first.