search

hedwig-im / hedwig

An Adapter-based Bot Framework for Elixir Applications
MIT License
650 stars 73 forks source link

Fix Elixir 1.5 compile warnings #71

Closed schlenks closed 6 years ago

schlenks commented 6 years ago

Fixes the Elixir 1.5 compile warnings when running mix hedwig.gen.robot

Added *.DS_Store to the .gitignore file as well to prevent accidental adding of macOS drive files.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 92.105% when pulling c47ef7d004fe987d74a7e3bd6aa38d2cb10f8798 on schlenks:fix_elixir_1_5_compile_warnings into bc8dfab94b95b14d56a9dcf133b5a19ace49c911 on hedwig-im:master.

scrogson commented 6 years ago

Hi there @schlenks!

Thanks for this PR. I've taken care of these changes in my robot_behaviour branch, but I'm not sure how long it's going to be before that's ready.

As for the .DS_Store files, those are normally things that belong in your global .gitignore file, so that they are ignored for all repositories. If you could remove that change, I'll go ahead and merge this.

👍

schlenks commented 6 years ago

Thanks for the review @scrogson, I've pulled the line out.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 92.105% when pulling dd7c1844328375e471a3daa20b15431e866782a4 on schlenks:fix_elixir_1_5_compile_warnings into bc8dfab94b95b14d56a9dcf133b5a19ace49c911 on hedwig-im:master.