Open MostHated opened 2 years ago
Hi, I think I know what's causing this inconsistent behaviour. I'll get to it as soon as I get the chance, thanks!
Hi, I think I know what's causing this inconsistent behaviour. I'll get to it as soon as I get the chance, thanks!
Hi, hedyhli. I like your project, so I want to work for this project. I check this issue and find the problem is your api(https://gtrend.yapie.me/languages) doesn't update with the language c#/csharp. If you have no time to do this, I am glad to fix this bug. Thanks for your Job!
It seems like the GitHub search API uses 'csharp' whereas GitHub Trending uses 'c#'. To have consistency we could change 'csharp' to 'c#' before calling the gtrending functions. Note that it appears there's also inconsistency with 'cpp' vs 'c++', possibly others too. It'd be nice to have all the language parameters for GitHub search work for GitHub Trending as well.
Apologies for the delay @Treehole, are you still interested in working on this?
Hello there! Could I give a try to this issue?
When filtering results, if using the language csharp on its own, it is fine, but if I add
-d today
, I get the error seen in the details dropdown below:Error details
`-l csharp -d today`
```sh zsh starcli -l csharp -d today Traceback (most recent call last): File "/home/mosthated/.pyenv/versions/3.9.9/bin/starcli", line 8, inJust to check, I also tried the following, and it worked fine:
Python version 3.9.9
your operating system (and terminal type or shell of needed)
System Details
```sh mosthated@pop-os ---------------- OS: Pop!_OS 21.10 x86_64 Host: X570 AORUS ELITE -CF Kernel: 5.15.15-76051515-generic Uptime: 7 days, 16 hours, 39 mins Packages: 3947 (dpkg), 194 (brew), 76 (flatpak), 13 (snap) Shell: zsh 5.8 Resolution: 1920x1080, 2560x1080, 1920x1080 DE: GNOME 40.5 WM: Mutter WM Theme: Materia-dark-compact Theme: Materia-dark-compact [GTK2/3] Icons: Flatery-Orange-Dark [GTK2/3] Terminal: alacritty CPU: AMD Ryzen 9 3950X (32) @ 3.500GHz GPU: NVIDIA GeForce RTX 2070 Memory: 53130MiB / 64314MiB ```starcli version starcli==2.17.1