hedyhli / starcli

:sparkles: Browse trending GitHub projects from your command line
https://pypi.org/project/starcli/
MIT License
547 stars 50 forks source link

fix(url): fix clickable repo name in grid/table layout #114

Closed tizee closed 1 year ago

tizee commented 2 years ago

Checklist

Description

Right now it only support clickable repo names in list layout by default.

        title = Text(repo["full_name"], overflow="fold")
        title.stylize(f"yellow link {repo['html_url']}")

Clickable links to repos are missing in both grid layout and table layout.

My PR added these missing links to get a coherent behavior of repo names across all layouts.

This PR also fixes #112

tizee commented 2 years ago

Maybe we can also update the README.md to include this existing feature because I notice that now there is words on it.

From the view of a new user, I have no clue that I could click and the name to jump unless I tried to do so in list layout. Hence, this incoherent behavior between list layout and others would make the user confused. Including this feature in the doc would make this tool more user-friendly.

hedyhli commented 1 year ago

This looks good, however I'll have to test this when I'm free. Thanks!

hedyhli commented 1 year ago

@allcontributors please add @tizee for code

allcontributors[bot] commented 1 year ago

@hedyhli

I've put up a pull request to add @tizee! :tada: