hedyhli / starcli

:sparkles: Browse trending GitHub projects from your command line
https://pypi.org/project/starcli/
MIT License
555 stars 50 forks source link

Added support for windows OS by modifying terminal_size method implementation #33

Closed Shagilton closed 4 years ago

Shagilton commented 4 years ago

This pull request is with regards to the issue #28 (adding support for windows OS)

Description Modified method to fetch terminal_size in order for it to support windows machines as well. Have replaced the old reference to fcntl library and have used shutil library method "get_terminal_size" instead.

Note: Was unable to run get the tests to pass, but i believe it was something to do with the project setup, and not the change itself.

hedyhli commented 4 years ago

Thank you for your contribution! I didn't know shutil had that method 😄 I will check it right now

hedyhli commented 4 years ago

Sorry for the force push, consider this merged, I will update the branch now, thanks again for your contribution :)

hedyhli commented 4 years ago

@all-contributors please add @Shagilton for code

allcontributors[bot] commented 4 years ago

@hedythedev

I've put up a pull request to add @Shagilton! :tada: