Feat/grid view - Githubissues

hedyhli / starcli

:sparkles: Browse trending GitHub projects from your command line

https://pypi.org/project/starcli/

MIT License

550 stars 50 forks source link

Feat/grid view #38

Closed swellander closed 4 years ago

swellander commented 4 years ago

Description

Implements a grid layout option. Screenshot

Context

Resolves Issue #23

More details

Repo names for this view don't link to their repos.
I had some trouble rendering emojis with the colon syntax (:star:) but using the unicode character directly seemed to work ok.

hedyhli commented 4 years ago

Thank you so much! I love the view seen in your screenshot, I will test it later, but the tests seems to be failing due to black formatting, don't worry about that at the moment, although if you have black installed you can run black . and push the changes. If you don't then don't worry about it 😀

hedyhli commented 4 years ago

Awesome! Looks gorgeous on my computer, thanks for your contribution ;)

hedyhli commented 4 years ago

@all-contributors please add @swellander for code

allcontributors[bot] commented 4 years ago

@hedythedev

I've put up a pull request to add @swellander! :tada:

hedyhli commented 4 years ago

✨ released on version 2.9.0, added you to list of contributors :)

willmcgugan commented 4 years ago

Hey. The grid layout looks great!

There is a gotcha to be aware of, with regards to truncating the title text with ellipsis. Asian characters can take up 2 “cells” in the terminal. So a title in Chinese may have a length of 10, but will be as wide as 20 characters of a Western alphabet.

You might want to use this method to truncate the title, which is aware of Asian characters.

hedyhli commented 4 years ago

Thanks for your suggestion, I will try it out :)