hedyhli / starcli

:sparkles: Browse trending GitHub projects from your command line
https://pypi.org/project/starcli/
MIT License
550 stars 50 forks source link

list layout refactor #47

Closed willmcgugan closed 4 years ago

willmcgugan commented 4 years ago

Description

Hi. This should fix any problems with Asian characters in the list layout. This is an interesting use of Rich so I was keen to see if I could make some refinements.

Hope you don't mind, I've also taken a few liberties with the layout. I've widened the column a little to 80 characters (but it will shrink if necessary). The sats and title will always be on the same line now, with the stats right aligned. Screenshot below...

Also update the table layout to take advantage of updates to the Table class, which handles compressed tables better and has an option to insert blank lines between rows.

Screen Shot 2020-07-12 at 12 43 01

Context

Resolves https://github.com/hedythedev/starcli/issues/46

More details

This uses a few features of Rich which are as yet undocumented.

hedyhli commented 4 years ago

Thank you! I’ll have a look 😄

hedyhli commented 4 years ago

looks like github was down when i merged this... I'm going to see what happens when I merge it again 🤔

hedyhli commented 4 years ago

oof looks like somethings wrong with github, because

well I added you to contributors list :) Thanks for improving my list layout!

hedyhli commented 4 years ago

@all-contributors please add @willmcgugan for code

allcontributors[bot] commented 4 years ago

@hedythedev

I've put up a pull request to add @willmcgugan! :tada:

hedyhli commented 4 years ago

thanks allcontributors bot