hedyhli / starcli

:sparkles: Browse trending GitHub projects from your command line
https://pypi.org/project/starcli/
MIT License
555 stars 50 forks source link

Added tests for multiple topics, created date, updated date, and stars. #55

Closed arcanearronax closed 4 years ago

arcanearronax commented 4 years ago

Added additional tests for multiple topics, created date, update date, and star count. The tests do fail occasionally, but this appears to be an issue in main as well. This will require a different commit to resolve.

arcanearronax commented 4 years ago

Added additional tests for multiple topics, updated date, add date, and star count. Modified a few comparisons to None to use "is None" rather than "== None", as advised by pylint.

hedyhli commented 4 years ago

Thanks @arcanearronax, before your latest commit I think that the tests failed because we used repo[‘updated_at’] Instead of repo[‘pushed_at’]

arcanearronax commented 4 years ago

I'll need to take a second look at that since I thought I verified the data point. Part of the issue I was running into was the unauthorized request limit since I was running into failures after repeated runs.

Once I'm back at my computer I'll open a bug to handle unauthorized requests, since those seem to result in unhandled key errors.

hedyhli commented 4 years ago

@allcontributors please add @arcanearronax for tests and code

allcontributors[bot] commented 4 years ago

@hedythedev

I've put up a pull request to add @arcanearronax! :tada: