search

hedyhli / starcli

:sparkles: Browse trending GitHub projects from your command line
https://pypi.org/project/starcli/
MIT License
555 stars 50 forks source link

Add spoken language #56

Closed Saif807380 closed 4 years ago

Saif807380 commented 4 years ago

Context

Added filtering by language spoken as a new option. Resolves #45

Description

Scraped GitHub Trending Page to allow filtering based on spoken languages. This option can be combined with filtering by programming languages, by number of stars, by limit of results, different layouts as well as asc/desc ordering of stars. Added the option with flags --spoken-language and -S.

I went ahead with scraping as GitHub Search API has no query parameter or endpoint for filtering by spoken language.

I have also added a json file that contains a list of all supported languages and their corresponding language codes. Also I have added the new feature to README.md file

Here's a preview of the option,

Screenshot 2020-07-20 at 14 00 17

I have used the zh language code, which stands for Chinese, in combination with other flags to display the results.

Saif807380 commented 4 years ago

Please add the spoken-languages.json file to codespell skip list as it is trying to read the language codes as common English words hence PR is failing checks.

Saif807380 commented 4 years ago

I have made all the mentioned changes.

hedyhli commented 4 years ago

use >= instead of == in requirements txt and setup.py would be better 🙂

Saif807380 commented 4 years ago

Done

hedyhli commented 4 years ago

@allcontributors please add @Saif807380 for code and docs

allcontributors[bot] commented 4 years ago

@hedythedev

I've put up a pull request to add @Saif807380! :tada: