Better debug logging - Use rich.logging

hedyhli / starcli

:sparkles: Browse trending GitHub projects from your command line

https://pypi.org/project/starcli/

MIT License

547 stars 50 forks source link

Better debug logging - Use rich.logging #81

Closed hedyhli closed 3 years ago

hedyhli commented 4 years ago

Description

Currently we are using the python print function to print debug info when users use --debug, it would be better practice to use a logger (rich.logging) to log debug information, as well as requests debug info

how do you think should it be implemented? (If possible)

Update debug_requests_on in search.py to use rich logger
Update debug print lines in search.py To use the logger
Update test_cli_debug In CLI tests if needed

ineelshah commented 3 years ago

What's the status of this?

hedyhli commented 3 years ago

feel free to pick it if you like :smile:

ineelshah commented 3 years ago

I am going to try helping with it.

ineelshah commented 3 years ago

Hi @hedythedev . Check it out. Hopefully solves it. Thanks for letting me solve it.